Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRSA has changed URLs from http to https #1010

Merged
merged 1 commit into from Jan 15, 2018

Conversation

keflavich
Copy link
Contributor

No description provided.

@astropy-bot
Copy link

astropy-bot bot commented Dec 17, 2017

Hi there @keflavich 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issues with this pull request:

  • The milestone has not been set (this can only be set by a maintainer)
  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix these? Thanks!

If there are any issues with this message, please report them here.

@pllim
Copy link
Member

pllim commented Dec 18, 2017

For the record, from Vandana Desai:

IRSA web services are transitioning to more secure "https" URLs. On Wednesday, December 20, all incoming web requests to http URLs at IRSA will be automatically redirected to https. Most browsers will have no difficulties with the change. However, scripts accessing IRSA's data access APIs may fail if they do not handle the redirect responses. For example, the popular "curl" utility does not follow such redirects automatically by default.

The recommended solution is to update references from "http" to "https" in the URLs used. All IRSA services already support the use of https, so users can proceed with updating and testing their software as soon as possible, to avoid potential disruption that might be caused if the software does not handle the http-to-https redirects smoothly.

@keflavich
Copy link
Contributor Author

The build failure is a deprecation warning fairly deep within votable. We should ignore this and raise an upstream issue.

@keflavich
Copy link
Contributor Author

It looks like there's already a solved upstream issue? astropy/astropy#6850 solved in astropy/astropy#6959

The failed build was on Tue Dec 5 20:11:19 UTC 2017, while the merge was on Tue Dec 12 17:33:54 2017, so I'll just restart the failed test.

@pllim
Copy link
Member

pllim commented Jan 10, 2018

Yes, should have been fixed upstream by astropy/astropy#6785.

@keflavich keflavich merged commit 22d6cbd into astropy:master Jan 15, 2018
@bsipocz bsipocz added this to the v0.3.7 milestone Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants