Add a module to query NEOs (From Poliastro) #1325
Conversation
|
Hello @shreyasbapat! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 06, 2019 at 07:20 Hours UTC |
| } | ||
| SBDB_URL = conf.sbdb_server | ||
| response = self._request( | ||
| "GET", SBDB_URL, params=payload, timeout=self.TIMEOUT) |
There was a problem hiding this comment.
Do you want to (optionally?) enable cacheing here?
|
|
||
| # response = requests.get(SBDB_URL, params=payload) | ||
| response.raise_for_status() | ||
| # soup = BeautifulSoup(response.text, "html.parser") |
There was a problem hiding this comment.
| # soup = BeautifulSoup(response.text, "html.parser") |
| from astropy.table import Table | ||
|
|
||
|
|
||
| def test_observations_from_spk_id(): |
There was a problem hiding this comment.
These are remote-data tests, right? They need to be tagged with @remote_data if so.
There was a problem hiding this comment.
Correct! I will tag them.
Also, I will add some local tests too.
|
We already have the jplsbdb module, so I wonder how much of this functionality complementary of what that module can do. My opinion is that querying a subclass of objects from the generic module should not be a new module itself. cc @mommermi |
|
It seems to me that all the data that can be queried from |
|
Thankyou @mommermi , @bsipocz and @keflavich for prompt replies :) |
|
Also, @mommermi , should I fix the issues pointed out by @keflavich or I should perhaps start working on the |
|
@mommermi I noticed you 👍'd the last comment by @shreyasbapat, but he asked an 'or' question. Could you clarify in text what you thing the right way forward is? i.e., should we close this PR? |
|
@keflavich I guess it's up to you whether you want to close this PR. To me it sounds like most of the functionality here is already present in jplhorizons or jplsbdb. @shreyasbapat is there anything in this PR that is not yet available in astroquery? (Except for the Dastcom5 module) |
|
It queries Neows service provided by JPL :). I don't know until what extent it coincides with SBDB. Yes, a small part of the PR also queries SBDB. If you think it does not have a lot of application, I can happily close it. I am already working on |
|
To me it still looks like it only wraps a convenience service that is actually covered by the current functionalities, so I'm going ahead and close this issue. Thanks @shreyasbapat for raising this issues. |
Hi!
As discussed on
astroquerychats some days ago!https://matrix.to/#/!DdazxkLDTPnBLekbbL:openastronomy.org/$153784692124yzLpI:openastronomy.org
We had a neos module in our library, poliastro which essentially makes it possible to search NEOs by name (also using wildcards), and get their orbits straight from NASA APIs, using some of the defined methods. We can plot the orbit of a NEOs in just 2-3 lines of code. We thought that contributing the NEOs code to astroquery will be a better idea as this will make it even more usable. See the short documentation of NEOs module here: http://docs.poliastro.space/en/latest/user_guide.html#working-with-neos And API reference here: http://docs.poliastro.space/en/latest/safe.html#module-poliastro.neos
I have added some tests for the same as well, kindly let me know the changes required. :)
cc @Juanlu001