Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set http user-agent when running Travis CI and AppVeyor #1394

Closed
wants to merge 1 commit into from
Closed

Set http user-agent when running Travis CI and AppVeyor #1394

wants to merge 1 commit into from

Conversation

kakirastern
Copy link
Contributor

@kakirastern kakirastern commented Mar 27, 2019

Fixes #1281.

Create environment variables in the astroquery/tests/test_internet.py files for both the Travis CI and AppVeyor, and then checked these are turned on in the respective .travis.yml and appveyor.yml .yml files by default. Finally, the http user-agent is changed in astroquery/tests/test_internet.py.

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #1394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   64.56%   64.56%           
=======================================
  Files         157      157           
  Lines       12228    12228           
=======================================
  Hits         7895     7895           
  Misses       4333     4333

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ad3b9...dbec424. Read the comment docs.

appveyor.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
astroquery/tests/test_internet.py Outdated Show resolved Hide resolved
astroquery/tests/test_internet.py Outdated Show resolved Hide resolved
@bsipocz
Copy link
Member

bsipocz commented Mar 27, 2019

You still need to change the Agent pending on the new variable.

@kakirastern
Copy link
Contributor Author

Thanks @bsipocz! Now, I see... Since by default the env variable CI=true, TRAVIS=true, and APPVEYOR - True, so I don't need to set these again in the .yml files. I will change the user-agent next.

@bsipocz
Copy link
Member

bsipocz commented Sep 19, 2019

#1307 has addressed this, it was just not xref-ed back to the issue.

@bsipocz bsipocz closed this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change HTTP user-agent when running CI
3 participants