Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Prevent blocking error in Travis CI #1661

Merged
merged 2 commits into from Mar 2, 2020
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Mar 2, 2020

The error on Travis CI:

error: [Errno 11] write could not complete without blocking
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='UTF8'>
BlockingIOError: [Errno 11] write could not complete without blocking

I am not sure if this will fix your problem or not but it's worth a try? If this doesn't work, be sure to revert the change. Solution based on travis-ci/travis-ci#8982 (comment) .

Others mentioned they put it in before_install but given that you use ci-helpers, I moved it to after you activated the conda env.

馃し鈥嶁檧

@bsipocz
Copy link
Member

bsipocz commented Mar 2, 2020

Thanks @pllim, I owe you my eternal gratitude.

If travis passes, I'll cherry pick the commit and try it directly on the test branch, as the issue didn't come up for a long time on PR runs, but only on direct pushes. If that's fine, too, I'll merge the PR.

@pllim
Copy link
Member Author

pllim commented Mar 2, 2020

LoL... No such module on Windows...

ModuleNotFoundError: No module named 'fcntl'

@bsipocz
Copy link
Member

bsipocz commented Mar 2, 2020

That's ok, it wasn't an issue to begin with on windows.

(also for the record, your investigation was rather nice, hiding the whole workaround in a stale-bot closed issue wasn't a super nice approach from the CI folks)

@pllim
Copy link
Member Author

pllim commented Mar 2, 2020

Well, it is green but should keep an eye on master for a while yet to see if we just got lucky or this is really the solution.

hiding the whole workaround in a stale-bot closed issue wasn't a super nice approach

I am surprised too. They did not even really explain the cause. I am glad we have Internet search. 馃槄

@bsipocz bsipocz merged commit d90b2db into astropy:master Mar 2, 2020
@bsipocz
Copy link
Member

bsipocz commented Mar 2, 2020

Thanks @pllim!

@pllim pllim deleted the patch-1 branch March 2, 2020 21:13
@pllim
Copy link
Member Author

pllim commented Mar 2, 2020

Let's hope you are not thanking me prematurely. 馃 馃槄

@bsipocz
Copy link
Member

bsipocz commented Mar 2, 2020

It was passing on the direct branch, too, so I'm confident 馃槄

@pllim
Copy link
Member Author

pllim commented Mar 2, 2020

First run after merge looked promising. Only remote data job failed and the failure is not this. 馃

= 9 failed, 1288 passed, 32 skipped, 7 xfailed, 2 xpassed in 2308.11s (0:38:28) =
WARNING: AstropyDeprecationWarning: The remote_data option should be one of none/astropy/any (found =any). For backward-compatibility, assuming 'any', but you should change the option to be one of the supported ones to avoid issues in future. [astropy.tests.runner]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants