Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic documentation clean up #1937

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

tinuademargaret
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1937 (a5cf56e) into main (4c33104) will decrease coverage by 0.00%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
- Coverage   63.41%   63.40%   -0.01%     
==========================================
  Files         131      131              
  Lines       17043    17044       +1     
==========================================
- Hits        10808    10807       -1     
- Misses       6235     6237       +2     
Impacted Files Coverage Δ
astroquery/esa/iso/core.py 64.58% <ø> (ø)
astroquery/atomic/core.py 35.77% <30.76%> (-1.12%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tinuademargaret tinuademargaret changed the title added remote data directive Atomic documentation clean up Jan 12, 2021
@bsipocz
Copy link
Member

bsipocz commented Jan 12, 2021

rule of thumb: no changelog for any doc or internal changes, it's only required for user-facing changes of functionalities.

@bsipocz bsipocz added the atomic label Jan 12, 2021
@bsipocz bsipocz added this to the v0.4.2 milestone Jan 12, 2021
@tinuademargaret
Copy link
Contributor Author

rule of thumb: no changelog for any doc or internal changes, it's only required for user-facing changes of functionalities.

oh I'm just seeing this comment. Noted

@bsipocz bsipocz modified the milestones: v0.4.2, v0.4.3 May 15, 2021
@bsipocz bsipocz removed this from the v0.4.3 milestone Jul 7, 2021
@bsipocz
Copy link
Member

bsipocz commented Mar 27, 2022

This requires the fix for #2338 and passes locally when the fixes are applied.

@bsipocz bsipocz added this to the v0.4.7 milestone Mar 27, 2022
@bsipocz bsipocz merged commit db3f08b into astropy:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants