Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esasky documentation cleanup #1971

Merged
merged 5 commits into from
Dec 1, 2022

Conversation

tinuademargaret
Copy link
Contributor

No description provided.

@astropy-bot astropy-bot bot added the esasky label Feb 2, 2021
@tinuademargaret tinuademargaret added this to the v0.4.2 milestone Feb 2, 2021
@bsipocz bsipocz modified the milestones: v0.4.2, v0.4.3 May 15, 2021
@bsipocz bsipocz removed this from the v0.4.3 milestone Jul 7, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #1971 (c77be56) into main (b0a89ed) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1971      +/-   ##
==========================================
+ Coverage   64.20%   64.34%   +0.13%     
==========================================
  Files         130      130              
  Lines       16881    16834      -47     
==========================================
- Hits        10838    10831       -7     
+ Misses       6043     6003      -40     
Impacted Files Coverage Δ
astroquery/utils/commons.py 75.00% <0.00%> (-0.15%) ⬇️
astroquery/cadc/core.py 81.04% <0.00%> (-0.14%) ⬇️
astroquery/alma/utils.py 32.35% <0.00%> (-0.08%) ⬇️
astroquery/alma/core.py 49.44% <0.00%> (+0.27%) ⬆️
...roquery/ipac/nexsci/nasa_exoplanet_archive/core.py 57.55% <0.00%> (+0.46%) ⬆️
astroquery/vo_conesearch/vos_catalog.py 69.51% <0.00%> (+1.11%) ⬆️
astroquery/vo_conesearch/validator/validate.py 19.69% <0.00%> (+2.27%) ⬆️
astroquery/vo_conesearch/validator/tstquery.py 32.00% <0.00%> (+3.87%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz marked this pull request as ready for review December 1, 2022 07:05
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote tests are all green locally!

@bsipocz bsipocz merged commit 285331d into astropy:main Dec 1, 2022
@bsipocz
Copy link
Member

bsipocz commented Dec 1, 2022

Thank you @tinumide! With this I suppose we finally wrapped up including all your work from Outreachy!

And hurray that we finally test the esasky module's extensive docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants