Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow html downloads with alma package #2246

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

andamian
Copy link

@andamian andamian commented Dec 8, 2021

Fix for #2138

The problem seems to be left-over code from the time the downloads were using the Web sites.

@andamian andamian added the alma label Dec 8, 2021
@andamian andamian added this to the v0.4.5 milestone Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #2246 (d2d045a) into main (4f29262) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   62.38%   62.38%           
=======================================
  Files         131      131           
  Lines       16777    16775    -2     
=======================================
- Hits        10466    10465    -1     
+ Misses       6311     6310    -1     
Impacted Files Coverage Δ
astroquery/alma/core.py 41.32% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f29262...d2d045a. Read the comment docs.

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keflavich keflavich merged commit 8a60cd2 into astropy:main Dec 10, 2021
@bsipocz
Copy link
Member

bsipocz commented Dec 13, 2021

Fix for #2138

nitpick, but the "magic" verbs should be right before the issue numbers to have them linked and then auto closed (https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)

@andamian andamian deleted the almafix branch December 21, 2021 00:00
@andamian
Copy link
Author

Fix for #2138

nitpick, but the "magic" verbs should be right before the issue numbers to have them linked and then auto closed (https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)

Thanks for the tip @bsipocz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants