Deprecate astroquery/utils/download_file_list.py
#2247
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2247 +/- ##
==========================================
+ Coverage 62.38% 62.40% +0.02%
==========================================
Files 131 131
Lines 16775 16777 +2
==========================================
+ Hits 10465 10470 +5
+ Misses 6310 6307 -3
Continue to review full report at Codecov.
|
|
This is a public function, so technically someone could be using it standalone. However, I don't think it's very likely since we didn't document it well. I'm ambivalent about removing this: since we don't use it, it's fine to remove, but it looks like something that could be useful. Within astroquery, though, we should stick to the other extensive download tools we've built. |
|
I'm cutting 0.4.5 this week, let's have this milestone for 4.0, we can merge this when we know for sure that it's the next one coming (I wish it was, but I cannot say it for sure as we need to do a lot of cleanup work for it). In the meantime I'm not opposed to have this merged whenever, of you decorate it as deprecation. |
|
Looks like deprecation is preferred over immediate removal. The module only provides one public function ( |
This commit deprecates the function `download_list_of_fitsfiles()`, and because that is the only public function defined by the aforementioned file then the whole file becomes deprecated.
eerovaher
force-pushed
the
rm-download-file-list
branch
from
2d84be1
to
a96365f
Compare
eerovaher
changed the title
astroquery/utils/download_file_list.pyastroquery/utils/download_file_list.py
|
Thanks, this is now uncontroversial. |
The contents of this file were not being used anywhere, so it should be safe to remove even without deprecating first.
EDIT: This pull request will deprecate the module, it will be removed later.