Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name convention for ESA modules #2260

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

jespinosaar
Copy link
Contributor

Hi @bsipocz ,

This is a small pull request to use the same naming convention for the titles of the modules under astroquery/esa folder. As you can see, the only changes are the titles of JWST, HST and XMM-Newton modules.

Just a question, how often is the documentation (https://astroquery.readthedocs.io/en/latest/) updated? I can see 'astroquery v0.4.6.dev2370' but maybe this is happening when releasing...

Thanks a lot!

Regards,

@jespinosaar

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #2260 (0851a40) into main (091b987) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2260   +/-   ##
=======================================
  Coverage   62.68%   62.68%           
=======================================
  Files         131      131           
  Lines       16818    16818           
=======================================
  Hits        10542    10542           
  Misses       6276     6276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091b987...0851a40. Read the comment docs.

@bsipocz bsipocz merged commit f4a0664 into astropy:main Jan 19, 2022
@bsipocz
Copy link
Member

bsipocz commented Jan 19, 2022

Thanks @jespinosaar! The docs page is updated after each commit (practically merge) to the main branch, assuming the RTD build is successful. So, I expect these to land on the page in a few minutes.

@jespinosaar
Copy link
Contributor Author

That was fast! many thanks for your support @bsipocz! I can confirm docs have been updated. See you on next PR!

@jespinosaar jespinosaar deleted the esa_module_names_in_doc branch January 21, 2022 09:50
@jaymedina jaymedina mentioned this pull request Jan 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants