Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining issues with spectra Sdss.query_crossid #2304

Merged
merged 5 commits into from
Feb 24, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Feb 23, 2022

This PR fixes the failing test added in #2258 and fixes the code itself. Changelog is included for both PRs here.

@bsipocz bsipocz added this to the v0.4.6 milestone Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #2304 (88c99be) into main (f99e1ba) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2304   +/-   ##
=======================================
  Coverage   62.84%   62.84%           
=======================================
  Files         130      130           
  Lines       16841    16841           
=======================================
  Hits        10584    10584           
  Misses       6257     6257           
Impacted Files Coverage Δ
astroquery/sdss/core.py 85.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99e1ba...88c99be. Read the comment docs.

@bsipocz bsipocz merged commit 9eb2278 into astropy:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants