Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude query parameters from file names is casda.download_file #2308

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

jd-au
Copy link
Contributor

@jd-au jd-au commented Feb 24, 2022

No description provided.

@bsipocz bsipocz added the casda label Feb 24, 2022
@bsipocz bsipocz added this to the v0.4.6 milestone Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #2308 (08e7ef2) into main (f99e1ba) will increase coverage by 0.12%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
+ Coverage   62.84%   62.97%   +0.12%     
==========================================
  Files         130      131       +1     
  Lines       16841    16922      +81     
==========================================
+ Hits        10584    10656      +72     
- Misses       6257     6266       +9     
Impacted Files Coverage Δ
astroquery/casda/core.py 90.39% <88.88%> (+3.18%) ⬆️
astroquery/mast/missions.py 79.45% <0.00%> (ø)
astroquery/mast/services.py 79.56% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99e1ba...08e7ef2. Read the comment docs.

@bsipocz
Copy link
Member

bsipocz commented Feb 24, 2022

Could you add a changelog entry, please?

@jd-au
Copy link
Contributor Author

jd-au commented Feb 24, 2022

Could you add a changelog entry, please?

All done

@bsipocz bsipocz added the bug label Feb 24, 2022
@bsipocz
Copy link
Member

bsipocz commented Feb 24, 2022

Thank you @jd-au!

@bsipocz bsipocz merged commit fa423aa into astropy:main Feb 24, 2022
@jd-au jd-au deleted the CASDA-7094-Filename-too-long branch February 24, 2022 05:57
@jd-au
Copy link
Contributor Author

jd-au commented Feb 24, 2022

Thanks @bsipocz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants