update domain in NOIRlab docs from noao.edu to noirlab.edu

[privong]

I noticed the documentation has links to noao.edu that no longer work. Minor change to update the URLs to noirlab.edu

[codecov]

Codecov Report

Merging #2324 (bcd2e6d) into main (d17805e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2324   +/-   ##
=======================================
  Coverage   62.98%   62.98%           
=======================================
  Files         131      131           
  Lines       17067    17067           
=======================================
  Hits        10749    10749           
  Misses       6318     6318           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[eerovaher]

Shouldn't the URL be changed in the noirlab subpackage code too?

astroquery/astroquery/noirlab/__init__.py

Lines 67 to 70 in d17805e

	server = _config.ConfigItem(
	['https://astroarchive.noao.edu',
	],
	'Name of the NOIRLAB server to use.'

And would changing the URL fix the remote tests that are reported as failing in #2203?

[privong]

@eerovaher Yes that should be updated too, but a simple update of the url in the module doesn't seem to result in a working query / submodule (see #2081). It might be better to leave the code changes to include whatever other changes are need to get the module working again.

[bsipocz]

We're seeing the remote test failures for a while, practically the module seems to be non-functional.

I'm cutting a release right now, so a quick "fix" would be to add a warning both into the code and at the top of the docs page. Then we would see if either someone (noirlab itself?) would pick up the task to fix it, or to deprecate and remove the module as we did with LCO.

ping @keflavich @ceb8

[keflavich]

👍 to putting a warning at the top

[pothiers]

I work at NOIRLab and have added an internal NOIRLab ticket to update astroquery to make this work again. A lot has changed on our side. Thanks @privong -- your @mention might be the only reason I saw this.

[bsipocz]

Let's have this in, and the large code update in a follow up as discussed. Thanks @privong for the reminder that changes are due to the module!