Cleanup test decorations #2327
Merged
Cleanup test decorations #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall it would be great to be able to cut back some on the slowest tests, maybe it's possible by working with smaller datasets? Either way, think this is an improvement. It's not release critical though, so I'll leave a chance for comments before merging. |
Codecov Report
@@ Coverage Diff @@
## main #2327 +/- ##
=======================================
Coverage 63.17% 63.17%
=======================================
Files 132 132
Lines 17189 17189
=======================================
Hits 10860 10860
Misses 6329 6329
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bsipocz
force-pushed
the
alma_slow_test_cleanup
branch
from
52eaf74
to
3fcff2b
Compare
|
I've changed the default test server to be the ESO one as it cuts back the test runtime from 40mins to 15min, even for based in Seattle. And CI is not located at nrao network either, all those closer to those other sources can use cc @keflavich whether this is OK. |
|
Updated timings after the rebase, on the same local computer using the eso site (just as it was used for the previous timings above): |
|
👍 to switching to ESO. I don't know what's up with the NRAO servers, but they have repeatedly and consistently been slow for me this year. |
bsipocz
force-pushed
the
alma_slow_test_cleanup
branch
from
3fcff2b
to
407dba7
Compare
bsipocz
force-pushed
the
alma_slow_test_cleanup
branch
from
407dba7
to
4fdc765
Compare
|
I'm going ahead and merge this now. One test that was skipped before is failing now, but that should be fixed separately as it seems to be a legit issue (and it shows that it's in fact valuable to not skip the tests :) ) Current timings, the docs could certainly use some fine tunings, as it even timed out around line 370 (maybe switching off from the nrao mirror hidden away in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove obsolete slow marks and change known failures to xfail
Most of these slow tests were decorated way back, and since then they seemed to be fixed. There are also a handful of tests that got decorated with skip due to a know failure, I've changed those to xfail which better reflects on their status.
So overall the changes are 36 pass 14 skip to 41 pass 4 skip 5 xfail, total runtime from 6 min to 7.25 min
The current durations: