MNT: cleanup test data #2342
Merged
MNT: cleanup test data #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
approved these changes
Mar 29, 2022
|
There are more to come, these are only the ones picked up by missing from the MANIFEST collection. |
|
OK, this is ready now. I haven't run remote tests on these changes, but we ideally should do that before merging to see nothing got broken due to these clearups. |
|
I've run the remote tests and none of them seems to be new and due to the changes in this PR (it's a bit difficult to say it for certain as the test suite runs for ~2hrs and has 41 failures, some of which are temporary flukes, etc.) |
bsipocz
force-pushed
the
MNT_test_data_fixes
branch
from
b416af5
to
e51d3ee
Compare
Codecov Report
@@ Coverage Diff @@
## main #2342 +/- ##
=======================================
Coverage 63.40% 63.40%
=======================================
Files 131 131
Lines 17044 17044
=======================================
Hits 10807 10807
Misses 6237 6237 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into some discrepancies while investigating the current CI failure (#2250 (comment)).
I've left alone two recently added, but yet unused test files as adding more testing is in the near future plans for that module (#2328 (comment))