A number of CADC authentication and doc fixes

[andamian]

• Added fix to use an authentication connection with datalink service (and not only with the tap service)
• Fixed a problem to handle a different type of exception raised the upstream stack (HTTPError)
• A few fixes to make documentation examples testable Upload example is broken for CADC docs #2372, Saving to file is broken for Cadc #2371, 401 error for Cadc.get_images() #2370.

[codecov]

Codecov Report

Merging #2374 (65627ee) into main (1f4e665) will increase coverage by 0.00%.
The diff coverage is 54.54%.

@@           Coverage Diff           @@
##             main    #2374   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files         132      132           
  Lines       17245    17256   +11     
=======================================
+ Hits        10916    10923    +7     
- Misses       6329     6333    +4     

Impacted Files	Coverage Δ
astroquery/cadc/core.py	76.87% <54.54%> (-0.52%)	⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[bsipocz]

This needs a rebase to get rid of the merge commit. I think that there maybe something off with on your fork as the change to setup.cfg keeps coming back.

Also, please add a changelog.

[bsipocz]

It would be great to keep a code example in the docs, so I would prefer if it would be fixed rather than just removed.

[andamian]

You suggest I should added back with the doctest-skip?

[bsipocz]

No, I only set it to skip as the example was broken. (Well, we would need a dummy file anyway, but the problem wasn't with the file itself). So if you suggest to temporarily remove it I'm on board with that one, but for the long term I would find it useful to have a working examples and not just the narrative description of how the file upload should work.

[andamian]

Done. I hope it's the correct way.

[andamian]

This needs a rebase to get rid of the merge commit. I think that there maybe something off with on your fork as the change to setup.cfg keeps coming back.

Also, please add a changelog.

Do I need a changelog even if the API and functionality are essentially the same (just added an extra attribute with a default to a method)?

[bsipocz]

Do I need a changelog even if the API and functionality are essentially the same (just added an extra attribute with a default to a method)?

OK, it's fine not to add one if you don't expect this to be directly used by users.

[bsipocz]

Thanks @andamian!

Version is on pypi.