-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: SBDB query return unit with exponentials #2377
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2377 +/- ##
=======================================
Coverage 63.29% 63.29%
=======================================
Files 132 132
Lines 17241 17245 +4
=======================================
+ Hits 10913 10916 +3
- Misses 6328 6329 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry, otherwise, it looks good to me.
I would wait a few days with the merge though to give a chance for Mike to review it, too.
I don't understand the failing check. CHANGES.rst was what I changed in the last two commits. Why did astropy-bot complain it's missing? Could someone help? |
|
Thanks @jianyangli! |
When SBDB query returns quantities that have units with exponentials, an error is issued because '^' is used to mark exponentials instead of '**' in the unit strings. Issue #2368 . This PR fixes this bug.