Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: SBDB query return unit with exponentials #2377

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

jianyangli
Copy link
Contributor

When SBDB query returns quantities that have units with exponentials, an error is issued because '^' is used to mark exponentials instead of '**' in the unit strings. Issue #2368 . This PR fixes this bug.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2377 (6329863) into main (d53047b) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #2377   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files         132      132           
  Lines       17241    17245    +4     
=======================================
+ Hits        10913    10916    +3     
- Misses       6328     6329    +1     
Impacted Files Coverage Δ
astroquery/jplsbdb/core.py 78.61% <75.00%> (-0.09%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry, otherwise, it looks good to me.

I would wait a few days with the merge though to give a chance for Mike to review it, too.

@jianyangli
Copy link
Contributor Author

I don't understand the failing check. CHANGES.rst was what I changed in the last two commits. Why did astropy-bot complain it's missing? Could someone help?

@bsipocz
Copy link
Member

bsipocz commented Apr 27, 2022

@jianyangli - The changelog needs the number of the PR rather than the issue referenced. Don't worry about it, I can fix up the changelog before releasing. apparently I was wrong, it rather looks like a fluke with the changelog bot.

@ceb8 ceb8 merged commit c2bfa20 into astropy:main Apr 27, 2022
@ceb8
Copy link
Member

ceb8 commented Apr 27, 2022

Thanks @jianyangli!

@jianyangli jianyangli deleted the fix_sbdb_import_unit_error branch April 27, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JPL SBDB query fails when returned properties have complex units with exponential involved
3 participants