Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: cleanup deprecations and obsolte checks #2389

Merged
merged 6 commits into from
May 4, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented May 3, 2022

  • PyVO is a required dependency now.

  • individual tests can be run with either python setup.py -t testfilename::testfunctionname or as pytest testfilename -k testfunctionname

  • 0.4.0 has been a while ago, deprecations are likely can be removed now

@bsipocz bsipocz added the cadc label May 3, 2022
@bsipocz bsipocz added this to the v0.4.7 milestone May 3, 2022
@bsipocz bsipocz requested a review from andamian May 3, 2022 04:23
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2389 (3aa91b4) into main (105d232) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2389      +/-   ##
==========================================
- Coverage   63.31%   62.87%   -0.44%     
==========================================
  Files         133      133              
  Lines       17271    17246      -25     
==========================================
- Hits        10935    10844      -91     
- Misses       6336     6402      +66     
Impacted Files Coverage Δ
astroquery/cadc/core.py 80.37% <100.00%> (+3.49%) ⬆️
astroquery/nrao/core.py 24.57% <0.00%> (-46.46%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link

@andamian andamian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the remote tests locally with more privileges as well as doctests and all passed.

@andamian
Copy link

andamian commented May 3, 2022

@bsipocz - thank you for doing this.

@bsipocz bsipocz merged commit 96f63eb into astropy:main May 4, 2022
@bsipocz
Copy link
Member Author

bsipocz commented May 4, 2022

@bsipocz - thank you for doing this.

No worries, PRs with negative lines bring me real joy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants