Add matplotlib as a 'docs' dependency
#2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation already contains plots, so `matplotlib` is required for building it. `matplotlib` does not have to be explicitly listed in the 'all' dependencies because it is included indirectly through `aplpy`.
The 'docs' optional dependencies should be all that is required for building the documentation, so Read the Docs should not be installing 'all' dependencies. [ci skip]
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation already contains plots, e.g.
astroquery/docs/linelists/cdms/cdms.rst
Line 159 in aaeccb8
matplotlibshould therefore be listed as a 'docs' dependency. It does not have to be listed in the 'all' dependencies because it is already included indirectly throughaplpy.The second commit tells Read the Docs to only install 'docs' dependencies because that should be all that is needed for building the documentation.