BUG: Fix OAC parsing issue #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 62.97% 62.97%
=======================================
Files 133 133
Lines 17290 17292 +2
=======================================
+ Hits 10888 10890 +2
Misses 6402 6402
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #1401 as well as to fix the now passing, previously xfailing tests.
First I was thinking of removing the
data_formatkwarg as it shouldn't be the concern of the users of which data format to receive the query response, but parsing the json into an astropy table is not trivial without pulling in pandas as a dependency. So I opted for a regex fix instead.