Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove xfail from passing test #2425

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 1, 2022

Currently, 4 remote alma tests are failing, one of them because it is passing as opposed to its xfail mark.

The other three are a different case, locally and on CI I see certificate issues like the one below. One puzzling question is why the tests use the noa.ac.jp mirror, as I recall we kind of hard wired the ESO server not long ago.

Maybe @keflavich or @andamian could have a look? (I suppose the first failure just requires to rework the test, or maybe even removing it as its name suggests that it served as testing the documentation (test_doc_example), however now we have doctest running on the narrative docs.

requests.exceptions.SSLError: HTTPSConnectionPool(host='almascience.nao.ac.jp', port=443): Max retries exceeded with url: /dataPortal/member.uid___A001_X1284_X1353.qa2_report.html (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)')))

@bsipocz bsipocz added this to the v0.4.7 milestone Jun 1, 2022
@bsipocz bsipocz merged commit 2543cc2 into astropy:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant