Log a warning if there are download duplicates for MAST #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
+ Coverage 62.97% 62.98% +0.01%
==========================================
Files 133 133
Lines 17308 17308
==========================================
+ Hits 10900 10902 +2
+ Misses 6408 6406 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
reviewed
Sep 7, 2022
astroquery/mast/observations.py
Outdated
| @@ -827,8 +827,8 @@ def _remove_duplicate_products(self, data_products): | |||
| unique_products = unique(data_products, keys="dataURI") | |||
| number_unique = len(unique_products) | |||
| if number_unique < number: | |||
| warnings.warn(f"{number - number_unique} of {number} products were duplicates." | |||
| f"Only downloading {number_unique} unique product(s).", DuplicateResultsWarning) | |||
| log.warning(f"{number - number_unique} of {number} products were duplicates. " | |||
There was a problem hiding this comment.
This feels more like an info level message, but we don't really have a clear policy on the boundaries, so you can keep it as a warning if you prefer.
There was a problem hiding this comment.
Agree. I will change it.
jdavies-st
force-pushed
the
mast-log-duplicate-warning
branch
from
be56800
to
f6ab293
Compare
jdavies-st
force-pushed
the
mast-log-duplicate-warning
branch
from
f6ab293
to
b348489
Compare
bsipocz
approved these changes
Sep 8, 2022
|
Thanks @jdavies-st! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR in response to #2497 (comment)
Instead of issuing a
warnings.warnwhen duplicate downloads are culled, this PR useslog.warning. I've removed the warning class I'd created and instead just logged the warning. Test is updated as well.