BUG: Fix SDSS parsing to directly use Table.read #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2518 +/- ##
==========================================
- Coverage 63.08% 63.07% -0.01%
==========================================
Files 133 133
Lines 17313 17310 -3
==========================================
- Hits 10922 10919 -3
Misses 6391 6391
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
11 tasks
bsipocz
force-pushed
the
warnings_remove_ignore_np_deprecation
branch
3 times, most recently
from
4b21c02
to
c547a29
Compare
bsipocz
force-pushed
the
warnings_remove_ignore_np_deprecation
branch
from
cf53c33
to
43926ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous solution raised a numpy VisibleDeprecationWarning, so this PR switches away from using np.genfromtxt and then converting to a Table in favour of using the ascii reader to get a Table in one step.