Shorten esa/jwst and gaia tests
#2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DummyResponse` is used in `esa/jwst` and `gaia` tests for mimicking server responses. Now the `message` attribute of an instance is automatically determined by its `status`, whereas previously it had to be set manually in a separate step. Furthermore, the `status` of a `DummyResponse` can now be set through `__init__()`.
`DummyResponse` is used in `esa/jwst` and `gaia` tests for mimicking server responses. Now the response data can be specified by only setting the parameters that have non-default values.
bsipocz
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a couple of small changes in the classes that are used for mocking server responses in
esa/jwstandgaiatests made it possible to shorten the tests quite a lot. This makes the current tests simpler to understand and any future tests simpler to write. See the commit messages for details.