Refactor gaia/tests/test_gaiatap.py
#2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section about server messages has been removed from `test_query_object()` because it duplicates code in `test_show_message()`.
The function `__check_results_column()` tested if the attributes (e.g. description) of the columns of the query results match the expectation. This function is now replaced with `astropy.table.BaseColumn.attrs_equal()`, and the comparison data is now provided by a `pytest` fixture.
The new module level fixtures allowed removing setup code from many tests.
By refactoring the code it was possible to shorten it without losing test coverage.
`pytest` produces informative assert failure messages automatically.
Grouping the tests together in a test class served no purpose and eliminating the class removed a level of indentation.
Codecov Report
@@ Coverage Diff @@
## main #2556 +/- ##
=======================================
Coverage 63.97% 63.97%
=======================================
Files 132 132
Lines 16984 16984
=======================================
Hits 10866 10866
Misses 6118 6118 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
One of the effects of astropy/astropy@e9d13fc is that `"_votable_string_dtype"` key together with the corresponding value gets added to the metadata of columns read from a VOTable. That commit is included in `astropy` versions 4.1 and later, but is missing from 4.0. The fixture that generates data for column attribute comparison in `gaia` tests now takes the `astropy` version into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to shorten the
gaianon-remote tests quite a lot without losing any test coverage. The refactored code is much less verbose and much easier to read. See the commit messages for more details.