Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: removal of non-functional Alfalfa.get_spetrum method #2578

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Nov 9, 2022

To close #2403

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #2578 (9ce71ea) into main (9f1a92f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2578      +/-   ##
==========================================
- Coverage   64.05%   64.02%   -0.03%     
==========================================
  Files         131      131              
  Lines       16913    16902      -11     
==========================================
- Hits        10834    10822      -12     
- Misses       6079     6080       +1     
Impacted Files Coverage Δ
astroquery/alfalfa/core.py 95.31% <100.00%> (-0.69%) ⬇️
astroquery/utils/commons.py 76.71% <0.00%> (-0.53%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz force-pushed the MAINT_remote_non_functional_alfalfa branch from 11be68a to 2757b93 Compare November 9, 2022 07:29
@bsipocz bsipocz force-pushed the MAINT_remote_non_functional_alfalfa branch from 2757b93 to 8378e7f Compare November 9, 2022 23:02
@bsipocz
Copy link
Member Author

bsipocz commented Nov 10, 2022

OK, let's go ahead with this one as we already discussed this in the tracking issue.

@bsipocz bsipocz merged commit b07d5db into astropy:main Nov 10, 2022
@bsipocz bsipocz deleted the MAINT_remote_non_functional_alfalfa branch April 9, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL error for Alfalfa.get_spectrum
1 participant