Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove not recommended api usage #2593

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Nov 18, 2022

We recommend using vectorized queries for APIs that support it, and afaik parallel_map type behaviour never really took off or was really recommended and in fact, explicitly discouraged in feedback from several archives.

this also closes #1846

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #2593 (60b5c71) into main (5b38065) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2593   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files         131      131           
  Lines       16914    16914           
=======================================
  Hits        10837    10837           
  Misses       6077     6077           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I think this example conflated the idea of performing several parallel downloads (which is often supported & useful) with several parallel queries, which is rarely useful and sometimes explicitly deprecated.

@bsipocz bsipocz merged commit 9d6c9b0 into astropy:main Nov 18, 2022
@bsipocz bsipocz deleted the docs_remove_parallel_map branch April 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a parallel_map function in astroquery.utils
2 participants