Refactor: make Vizier kwargs keyword-only

[keflavich]

See #1746.

This refactor raises a question: should we keyword-only the "private" functions too?

[codecov]

Codecov Report

Merging #2610 (283c8c4) into main (2ac0cb8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 283c8c4 differs from pull request most recent head c024d54. Consider uploading reports for the commit c024d54 to get more accurate results

@@           Coverage Diff           @@
##             main    #2610   +/-   ##
=======================================
  Coverage   64.20%   64.20%           
=======================================
  Files         130      130           
  Lines       16892    16892           
=======================================
  Hits        10845    10845           
  Misses       6047     6047           

Impacted Files	Coverage Δ
astroquery/vizier/core.py	78.59% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[bsipocz]

Hahh, was about to push the same changes 😄

I go ahead and merge this, so the new PR can be on top of this.

[keflavich]

There's a bug in the docs that I was working on - should I put this down for now?

[bsipocz]

Minor fix for sphinx

[bsipocz]

There's a bug in the docs that I was working on - should I put this down for now?

I didn't touch the docs, we don't yet have it included in the tests, so it doesn't come up as a failure.

[keflavich]

I meant the docstr fix you suggested - I pushed it before I saw your suggestion =)

[keflavich]

What about changelog? Should we individually changelog these?

[bsipocz]

Yes, changelog is needed, but I just go ahead with the merge and include its changelog in the new PR.