Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Replace print with log where necessary #2619

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Dec 1, 2022

This is a redo PR for the changes still relevant from #1853

@bsipocz
Copy link
Member Author

bsipocz commented Dec 1, 2022

cc @imbasimba and @jespinosaar to check whether these print --> log.info changes indeed make sense for quieting down the utils.tap module.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #2619 (d32f1bd) into main (285331d) will decrease coverage by 0.00%.
The diff coverage is 12.00%.

❗ Current head d32f1bd differs from pull request most recent head 44d6ca7. Consider uploading reports for the commit 44d6ca7 to get more accurate results

@@            Coverage Diff             @@
##             main    #2619      +/-   ##
==========================================
- Coverage   64.34%   64.33%   -0.01%     
==========================================
  Files         130      130              
  Lines       16834    16836       +2     
==========================================
+ Hits        10831    10832       +1     
- Misses       6003     6004       +1     
Impacted Files Coverage Δ
astroquery/eso/core.py 29.09% <0.00%> (ø)
astroquery/utils/tap/core.py 44.50% <10.52%> (-0.05%) ⬇️
astroquery/utils/tap/model/job.py 65.10% <33.33%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jespinosaar
Copy link
Contributor

Hi @bsipocz , it is ok from our side to log these messages instead of printing them. Thanks!

@bsipocz bsipocz merged commit e73c871 into astropy:main Dec 2, 2022
@bsipocz bsipocz deleted the redo_pr1853 branch April 9, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants