Refactor: Made NVAS optional kwargs keyword only #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2656 +/- ##
=======================================
Coverage 68.87% 68.87%
=======================================
Files 304 304
Lines 22529 22529
=======================================
Hits 15516 15516
Misses 7013 7013
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
If this PR works for you'll, I'll try a grouping of whats still listed in #1746 in another PR next week. |
bsipocz
approved these changes
Feb 8, 2023
|
Thanks @nkphysics! Having one PR for the rest (or multiple) of the remaining modules would be awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored nvas to make optional kwargs keyword only.
Addresses nvas on list for #1746
Tests (remote, local, and docs) should be passing.