Remove astroquery.utils.commons.radius_to_unit()
#2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`radius_to_unit(radius, unit)` was equivalent to `astropy.coordinates.Angle(radius).to_value(unit)` except that if `unit` was not specified then it defaulted to degrees. The convenience of not having to specify degrees was not worth obscuring the simple `Angle.to_value()` call, so the function has been removed.
bsipocz
approved these changes
Feb 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #2667 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 304 304
Lines 22529 22520 -9
=======================================
- Hits 15585 15579 -6
+ Misses 6944 6941 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
`astropy.units` is now imported as `u` like recommended by `astropy`. Furthermore, a line tried to use `astropy.io.fits...` despite the module using `from astropy.io import fits`.
eerovaher
force-pushed
the
rm-radius_to_unit
branch
from
5330190
to
87096d2
Compare
|
Thanks @eerovaher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radius_to_unit(radius, unit)is equivalent toastropy.coordinates.Angle(radius).to_value(unit)except that ifunitis not specified then it defaults to degrees. The convenience of not having to specify degrees is not worth obscuring the simpleAngle.to_value()call, so this pull request removes the function.Contributes towards #2429