Make utils and utis/tap kwargs keyword only #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkphysics
force-pushed
the
utls-kwarg-konly
branch
from
a27ed43
to
f0c761c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2690 +/- ##
=======================================
Coverage ? 65.73%
=======================================
Files ? 233
Lines ? 17841
Branches ? 0
=======================================
Hits ? 11728
Misses ? 6113
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nkphysics
commented
Mar 21, 2023
| @@ -12,7 +12,7 @@ class MockResponse: | |||
| A mocked/non-remote version of `astroquery.query.AstroResponse` | |||
| """ | |||
|
|
|||
| def __init__(self, content=None, url=None, headers={}, content_type=None, | |||
| def __init__(self, content=None, *, url=None, headers={}, content_type=None, | |||
There was a problem hiding this comment.
This content kwarg is the only kwarg that I've had to leave to be positional since the majority of the packages' testing uses it positionally. Otherwise most of the packages' testing would need to be refactored.
|
I can't seem to figure out where these 2 additional misses in utils/tap/ are that codecov is reporting. |
nkphysics
force-pushed
the
utls-kwarg-konly
branch
from
9446561
to
395d38d
Compare
|
Ok, I figured out why codecov was mad... Should be ok now. |
|
This should be ready for review. |
bsipocz
approved these changes
Apr 4, 2023
docs/esa/hubble/hubble.rst
Outdated
| >>> esahubble.get_postcard(observation_id="j6fl25s4q", calibration_level="RAW", resolution=256, filename="raw_postcard_for_j6fl25s4q.jpg") # doctest: +IGNORE_OUTPUT | ||
| >>> esahubble.get_postcard("j6fl25s4q", calibration_level="RAW", resolution=256, filename="raw_postcard_for_j6fl25s4q.jpg") # doctest: +IGNORE_OUTPUT |
|
Thanks @nkphysics! |
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address #1746 by making kwargs keyword only for utils and utils/tap.
As I expected, there are many packages that use some of these kwargs in a positional manner. So these changes have broken many packages. I started working though the packages to make the necessary changes so everything not listed in #2634 works again.
Like PRs I've done before here, I'm doing this pretty modularly so I figured I'd create the PR to get some input from yall on whether or not you want me to squash all the fixes to the different packages since in some cases its a 1-3 line change.