eJWST - Instrument search updated and bugfixes

[jespinosaar]

Dear astroquery team,

I am creating this pull request to include some small changes in how searching for instrument is being done in ESA JWST module and to fix some bugs we have found executing the tests (mostly remote testing and code in the documentation). Thanks in advance for your support!

cc @esdc-esac-esa-int

[codecov]

Codecov Report

Merging #2691 (5601454) into main (2facaed) will increase coverage by 0.03%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
+ Coverage   69.40%   69.44%   +0.03%     
==========================================
  Files         304      304              
  Lines       22445    22457      +12     
==========================================
+ Hits        15579    15595      +16     
+ Misses       6866     6862       -4     

Impacted Files	Coverage Δ
astroquery/esa/xmm_newton/__init__.py	100.00% <ø> (ø)
astroquery/esa/xmm_newton/core.py	64.35% <ø> (ø)
astroquery/esa/xmm_newton/tests/__init__.py	100.00% <ø> (ø)
astroquery/esa/xmm_newton/tests/dummy_handler.py	80.00% <ø> (ø)
...troquery/esa/xmm_newton/tests/dummy_tap_handler.py	86.27% <ø> (ø)
astroquery/esa/xmm_newton/tests/setup_package.py	60.00% <ø> (ø)
astroquery/esa/xmm_newton/tests/test_xmm_newton.py	92.03% <ø> (ø)
...ery/esa/xmm_newton/tests/test_xmm_newton_remote.py	27.08% <16.66%> (+0.20%)	⬆️
astroquery/esa/jwst/core.py	75.87% <66.66%> (+0.21%)	⬆️
astroquery/esa/iso/__init__.py	100.00% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jespinosaar]

Dear all,

I think all the tests are ok, please let me know if you have further comments.

[bsipocz]

Borderline whether this needs a changelog for the instrument query changes. As I see we haven't had a use case in the test suite that has actually run into the case sensitivity/insensitivity question, and we received no bug reports about it, yet you may want to mention it in the changelog.

The rest of the fixes are greatly appreciated.

I go ahead and merge this now, as the fixes are good, and let me know about the changelog, we can always add even after the merg.

[jespinosaar]

Dear @bsipocz ,

Many thanks for merging this! I think no bugs are being reported as we discovered it right after a reprocessing was executed but it was going to affect how the instruments were filtered. I forgot to include anything in the changelog, but if you want to I can add it in other PR.

Regards,
Javi