Exclude all test files from code coverage analysis #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously test directories were only excluded from coverage analysis if they were just under `astroquery` or separated from it by one directory, but now all directories named `tests` are excluded no matter how deep in the directory hierarchy they are.
|
Thanks, this indeed makes some sense. One case though where it could be beneficial to have coverage, is the mock classes, e.g. see astropy/pyvo#433 for a similar issue. E.g. when a mock class is more feature rich than the actual tests using the class, a situation that could be somewhat misleading for the reader of the test file (e.g. seeing/extending the class with things only assumed to be used in the tests). |
bsipocz
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently test directories are only excluded from coverage analysis if they are just under
astroqueryor separated from it by one directory, which means code in e.g.astroquery/esa/hsa/tests/test_hsa_remote.pyis included in coverage analysis. The updated configuration in this pull request ensures all directories namedtestsare excluded no matter how deep in the directory hierarchy they are. See also https://coverage.readthedocs.io/en/7.2.2/source.html#file-patterns