Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fixing examples that caused remote test failures #2721

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 28, 2023

This should fix most examples in the documentation. The remaining failures are due to genuine upstream problems and all have their tracking issues opened.

Besides these, there are a few more remote-data tests failing in the main test suite, I leave those for a future PR.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #2721 (486a777) into main (630686c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2721   +/-   ##
=======================================
  Coverage   65.74%   65.74%           
=======================================
  Files         233      233           
  Lines       17844    17844           
=======================================
  Hits        11732    11732           
  Misses       6112     6112           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor (single-character) comments, otherwise good

docs/casda/casda.rst Show resolved Hide resolved
docs/casda/casda.rst Show resolved Hide resolved
@bsipocz bsipocz merged commit 88d4921 into astropy:main Apr 28, 2023
9 checks passed
@bsipocz bsipocz deleted the DOC_fixing_failing_doc_examples branch December 8, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants