Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Introduction section #2725

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Added Introduction section #2725

merged 1 commit into from
Jun 7, 2023

Conversation

mstcyr2
Copy link
Contributor

@mstcyr2 mstcyr2 commented May 3, 2023

Adding introduction section to astroquery.mast docs.

@mstcyr2 mstcyr2 marked this pull request as draft May 3, 2023 20:53
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #2725 (dca6af1) into main (7277870) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head dca6af1 differs from pull request most recent head c03b91d. Consider uploading reports for the commit c03b91d to get more accurate results

@@           Coverage Diff           @@
##             main    #2725   +/-   ##
=======================================
  Coverage   65.86%   65.87%           
=======================================
  Files         233      233           
  Lines       17907    17904    -3     
=======================================
- Hits        11795    11794    -1     
+ Misses       6112     6110    -2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/mast/mast.rst Outdated Show resolved Hide resolved
@mstcyr2 mstcyr2 marked this pull request as ready for review May 10, 2023 20:47
docs/mast/mast.rst Outdated Show resolved Hide resolved
@bsipocz
Copy link
Member

bsipocz commented May 17, 2023

@jaymedina - If you and Makayla are up for it, this maybe an easy PR to practice squashing.

Copy link
Contributor

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd like to see the intro section beefed up a little bit more. Maybe briefly talk about the 3 different services offered: Observations (observations.py), Catalogs (cutouts.py) and Cutouts (cutouts.py) and give a quick overview of their purpose based on what you read about them in the documentation. I'd also like to read a little bit more about MAST and what it offers to the astro community. You can use resources like this to help form your statements.

docs/mast/mast.rst Show resolved Hide resolved
docs/mast/mast.rst Outdated Show resolved Hide resolved
@mstcyr2 mstcyr2 force-pushed the mast-docs branch 2 times, most recently from 7e8da95 to d4a39cb Compare May 18, 2023 21:08
docs/mast/mast.rst Outdated Show resolved Hide resolved
docs/mast/mast.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mstcyr2
Copy link
Contributor Author

mstcyr2 commented Jun 7, 2023

@bsipocz I think this is ready to merge, do I need to rebase?

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look all good @mstcyr2, thank you!

@bsipocz
Copy link
Member

bsipocz commented Jun 7, 2023

@mstcyr2 - I don't see a conflict, nor a code that could actually fail, so no need to rebase. Thanks for the squash and iterations!

@bsipocz bsipocz merged commit 6c5e6ff into astropy:main Jun 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants