Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix atomic URL #2769

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Fix atomic URL #2769

merged 4 commits into from
Jul 7, 2023

Conversation

keflavich
Copy link
Contributor

@keflavich keflavich commented Jul 7, 2023 •
edited by bsipocz

Fix #2767.

Includes slightly improved error handling for a new known error message.

@bsipocz bsipocz added this to the v0.4.7 milestone Jul 7, 2023
bsipocz
bsipocz reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do add a changelog entry too, please.

astroquery/atomic/core.py Show resolved Hide resolved
@keflavich
Copy link
Contributor Author

Looks like this is good to merge - want me to squash first?

@bsipocz
Copy link
Member

bsipocz commented Jul 7, 2023

Thanks @keflavich!

@bsipocz bsipocz merged commit aff2ac5 into astropy:main Jul 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees
No one assigned
Labels
atomic bug Upstream
Projects
None yet
Milestone
v0.4.7
Development

Successfully merging this pull request may close these issues.

AtomicLineList parsing issue
2 participants
@keflavich @bsipocz