Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New retrieval types for Gaia Datalink (GAIAPCR-1281 C9GACS-9070) #2775

Merged

Conversation

cosmoJFH
Copy link

We include new retrieval types for data link that will be used in DR4:

  1. 'EPOCH_ASTROMETRY',
  2. 'RV_EPOCH_SINGLE',
  3. 'RV_EPOCH_DOUBLE',
  4. 'RVS_EPOCH',
  5. 'RVS_TRANSIT'

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #2775 (85e0a37) into main (97efa55) will increase coverage by 0.02%.
Report is 21 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
+ Coverage   66.09%   66.11%   +0.02%     
==========================================
  Files         235      235              
  Lines       18071    18077       +6     
==========================================
+ Hits        11944    11952       +8     
+ Misses       6127     6125       -2     
Files Changed Coverage Δ
astroquery/gaia/__init__.py 100.00% <ø> (ø)
astroquery/gaia/core.py 70.77% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz
Copy link
Member

bsipocz commented Jul 21, 2023

@cosmoJFH - could you please provide more context and references? Are these already available with DR3 (as that is our default, and afaik the latest).

@bsipocz bsipocz added the gaia label Jul 21, 2023
@cosmoJFH
Copy link
Author

cosmoJFH commented Aug 1, 2023

Dear @bsipocz , for the Gaia FPR (Focused Product Release) that will be take place on the 10th of October 2023, the datatlink service needs to provide the new retrieval types

'EPOCH_ASTROMETRY',
'RV_EPOCH_SINGLE',
'RV_EPOCH_DOUBLE',
'RVS_EPOCH',
'RVS_TRANSIT'

.These will also be needed for the the Gaia Data release 4 (https://www.cosmos.esa.int/web/gaia/release#:~:text=Gaia%20FPR%20(Focused%20Product%20Release)%2010%20October%202023&text=The%20first%20results%20of%20quasars,data%20for%20Long%20Period%20Variables.)

This is the first change that we'd have to do in astroquery in order to provide access to the new products of datalink (https://www.cosmos.esa.int/web/gaia-users/archive/datalink-products).

Not that although the new products associated to these retrieval types are not public yet, we need to have this change in place asap.

@cosmoJFH cosmoJFH changed the title GAIAPCR-1281 C9GACS-907 Datalink for DR4INT2- astroquery tests New retrieval types for Gaia Datalink (GAIAPCR-1281 C9GACS-9070) Aug 1, 2023
@bsipocz bsipocz added this to the v0.4.7 milestone Aug 1, 2023
@bsipocz
Copy link
Member

bsipocz commented Aug 1, 2023

Not that although the new products associated to these retrieval types are not public yet, we need to have this change in place asap.

Given that this doesn't seem to broke any current functionality, I will go ahead and merge it, I suppose while currently these don't do anything (and therefore it's not really the typical workflow to get it merged just yet), having compatibility in older versions with DR4 won't hurt.

astroquery/gaia/core.py Outdated Show resolved Hide resolved
@bsipocz bsipocz merged commit fa181fa into astropy:main Aug 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants