Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: no milestone check with changelog, but use milestone action #2796

Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 1, 2023

No description provided.

@bsipocz bsipocz force-pushed the ci_no_changelog_milestone_but_milestonebot branch from 220b9f0 to ba39fb2 Compare August 1, 2023 20:32
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2796 (ba39fb2) into main (fa181fa) will increase coverage by 0.00%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2796   +/-   ##
=======================================
  Coverage   66.11%   66.12%           
=======================================
  Files         235      235           
  Lines       18077    18080    +3     
=======================================
+ Hits        11952    11955    +3     
  Misses       6125     6125           

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2023

This should work, but if not, I'll fix it incrementally (it's not really possible to do fixed in the PRs anyway as the action should only run on merge.

@bsipocz bsipocz merged commit ad50183 into astropy:main Aug 1, 2023
10 of 11 checks passed
@bsipocz bsipocz deleted the ci_no_changelog_milestone_but_milestonebot branch December 8, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant