Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix numpy dev version as their versioning system changed #2814

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 16, 2023

Numpy's versioning has changed in numpy/numpy#24196 causing the repr issues we see in #2811

This PR fixes #2811

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2814 (65f4394) into main (88dd76d) will increase coverage by 0.14%.
Report is 12 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
+ Coverage   66.17%   66.31%   +0.14%     
==========================================
  Files         235      235              
  Lines       18109    18135      +26     
==========================================
+ Hits        11983    12026      +43     
+ Misses       6126     6109      -17     
Files Changed Coverage Δ
astroquery/conftest.py 81.08% <100.00%> (ø)
astroquery/jplhorizons/core.py 72.55% <100.00%> (+7.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz merged commit 6267912 into astropy:main Aug 16, 2023
10 checks passed
@pllim
Copy link
Member

pllim commented Aug 17, 2023

Maybe minversion(np, "2.0.0.dev") is enough? It is uncommon for people to test against older dev wheels (and not sure if they even keep it on server).

@bsipocz bsipocz deleted the BUG_change_of_np_versioning branch August 17, 2023 14:23
@bsipocz
Copy link
Member Author

bsipocz commented Aug 17, 2023

I was overly pedantic, people may not use old wheels, but I certainly have various 2.0dev versions on my branches, and I really like to have one may dev environment 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: cadc invompatibility with dev versions of numpy
2 participants