Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: ipac.irsa to have SIA backend #2837

Merged
merged 8 commits into from
Jan 28, 2024
Merged

ENH: ipac.irsa to have SIA backend #2837

merged 8 commits into from
Jan 28, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Sep 20, 2023

This will need more convenience functions on top, as well as handling the duality that some datasets are SIA while others are already SIA2.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6205887) 67.02% compared to head (c39384c) 66.33%.
Report is 69 commits behind head on main.

❗ Current head c39384c differs from pull request most recent head f8f36eb. Consider uploading reports for the commit f8f36eb to get more accurate results

Files Patch % Lines
astroquery/ipac/irsa/core.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
- Coverage   67.02%   66.33%   -0.69%     
==========================================
  Files         235      235              
  Lines       18157    18089      -68     
==========================================
- Hits        12169    12000     -169     
- Misses       5988     6089     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz marked this pull request as ready for review January 28, 2024 07:44
@bsipocz bsipocz force-pushed the irsa_sia branch 2 times, most recently from 05cf73e to d8809bd Compare January 28, 2024 08:06
@bsipocz
Copy link
Member Author

bsipocz commented Jan 28, 2024

I'm running into some local issues with the docs build, so using the PR to see whether the plot/etc works as intended or not. Otherwise, this should be good to go, at least as the zeroth order addition, with further improvements planned in follow-up PRs.

astroquery/ipac/irsa/core.py Show resolved Hide resolved
docs/ipac/irsa/irsa.rst Show resolved Hide resolved
@bsipocz
Copy link
Member Author

bsipocz commented Jan 28, 2024

I'm not sure what's going on with the 3.8 build, but it's unrelated and is present on main, too, so I would go ahead and merge this now.

@bsipocz bsipocz merged commit 70762dc into astropy:main Jan 28, 2024
6 of 8 checks passed
@bsipocz bsipocz deleted the irsa_sia branch April 6, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants