-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: ipac.irsa to have SIA backend #2837
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
==========================================
- Coverage 67.02% 66.33% -0.69%
==========================================
Files 235 235
Lines 18157 18089 -68
==========================================
- Hits 12169 12000 -169
- Misses 5988 6089 +101 ☔ View full report in Codecov by Sentry. |
05cf73e
to
d8809bd
Compare
I'm running into some local issues with the docs build, so using the PR to see whether the plot/etc works as intended or not. Otherwise, this should be good to go, at least as the zeroth order addition, with further improvements planned in follow-up PRs. |
I'm not sure what's going on with the 3.8 build, but it's unrelated and is present on |
This will need more convenience functions on top, as well as handling the duality that some datasets are SIA while others are already SIA2.