Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Create test files in tmp dirs #2903

Merged
merged 1 commit into from
Dec 20, 2023
Merged

BUG: Create test files in tmp dirs #2903

merged 1 commit into from
Dec 20, 2023

Conversation

szampier
Copy link
Contributor

Fixes #2902

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a725c7a) 67.23% compared to head (910d2be) 67.23%.

❗ Current head 910d2be differs from pull request most recent head 5bd1c81. Consider uploading reports for the commit 5bd1c81 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2903   +/-   ##
=======================================
  Coverage   67.23%   67.23%           
=======================================
  Files         235      235           
  Lines       18155    18155           
=======================================
  Hits        12207    12207           
  Misses       5948     5948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szampier szampier changed the title BUG: Create test files in tmp dirs (#2902) BUG: Create test files in tmp dirs Dec 20, 2023
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the speedy turnaround.

All looks good except for the changelog (we don't need one for these types of changes), so I'll go ahead and remove that commit before merging.

CHANGES.rst Outdated
- Update tests and documentation.
- Create test files in temporary directories. [#2903]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: we don't do changelog for non-user facing changes or non-code changes, anything touching only tests/docs/ci, etc.

@bsipocz bsipocz added this to the v0.4.7 milestone Dec 20, 2023
@bsipocz bsipocz merged commit 9387c45 into astropy:main Dec 20, 2023
16 of 18 checks passed
@szampier szampier deleted the fix_2902 branch April 5, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST BUG: ESO test files should be in tmp dirs
2 participants