Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: flagging the SHA module for removal #2924

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jan 11, 2024

I run into failures in #2906 coming from the SHA module, so this deprecation cannot be postponed any longer.

The Spitzer datasets should be accessible via the more standard IRSA VO tools, the one missing step (besides actually removing the module) is to write more documentation with Spitzer examples (#2834)

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f63cd84) 67.30% compared to head (0363bf4) 67.08%.
Report is 9 commits behind head on main.

❗ Current head 0363bf4 differs from pull request most recent head ab4c4d3. Consider uploading reports for the commit ab4c4d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
- Coverage   67.30%   67.08%   -0.23%     
==========================================
  Files         235      235              
  Lines       18135    18135              
==========================================
- Hits        12206    12166      -40     
- Misses       5929     5969      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz merged commit ecde8f8 into astropy:main Jan 11, 2024
8 checks passed
@bsipocz bsipocz deleted the DEP_SHA branch April 6, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant