Sdss fixes python3 #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse directly the returned text, rather than encapsulating it in a file object with io.StringIO.
|
Done for now. Ready for review... |
|
The three commits above are now part of pull request #84. Closing... |
|
@keflavich - Would you take more commits on SDSS, or should I wait for the python3 merges you are working on? |
|
I merged #84 so that you can continue development on that. Go ahead and submit more PRs. This is a high-activity clean-up phase, so I'm OK with merging in a lot of changes rather rapidly. Also, that commit looks awesomely simplifying. |
|
Sweet! On my way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mirochaj, I don't think I have changed any of the interfaces, but you might want to check.
I may still be able to clean the io.StringIO part a little more. Will let you know when ready to merge.