A few more things with the astroquery.mast ObservationsClass

[ceb8]

Follow on pull request to #937, did the following:

• Added content testing
• Made all function arguments under_score
• Added convenience functions "list_collections" to list all data collections that can be queried for observation data

[pep8speaks]

Hello @ceb8! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 21, 2017 at 22:46 Hours UTC

[astropy-bot]

Hi there @ceb8 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issue with this pull request:

• Changelog entry section (v0.3.7) inconsistent with milestone (0.3.7)

Would it be possible to fix this? Thanks!

[bsipocz]

@ceb8 - We're experimenting with this new bot, you can ignore its comments for now or can add a one liner to the CHANGES file about list_missions()

[pllim]

Unrelated: How did astropy-bot get a "bot" label next to its username but not pep8speaks? Is this a sentient version of astrobot?

[bsipocz]

@pllim - Yes, @astrofrog is experimenting with a clever bot and we use astroquery as a playground for it. I guess pep8speaks is older and uses oath rather than the new github integration features that was just released a month ago.

Btw have you seen that besides the comment, there is now an astro-bot status below?

[pllim]

there is now an astro-bot status below?

Oh, I didn't because I was using mobile web UI on my phone. This is cool! It is only a matter of time before astropy-bot takes over the world.

[ceb8]

@bsipocz I left the change log alone because adding to it was causing conflicts.

[bsipocz]

@ceb8 - No worries, I can add the changelog before merging. Otherwise you could try and rebase this. (Usually it's advised to start every new feature branch from the top of the latest master, so there will be a smaller chance of conflicts)

[ceb8]

@bsipocz I'll let you add it before merging. Thanks!

Also, where can I find astroquery news? Like where do releases/updates get announced?

[pllim]

I believe astropy-dev mailing list.

[keflavich]

....which we need to do for 0.3.6. After the 0.3.6.post1 release.

…

On Thu, Jul 6, 2017 at 7:24 AM, P. L. Lim ***@***.***> wrote: I believe astropy-dev mailing list. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#947 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIxY4an9SIcfb3v9Gqc2ji_jEZpf90Kks5sLN__gaJpZM4OM0G5> .

-- Adam Ginsburg Jansky fellow, National Radio Astronomy Observatory http://www.adamgginsburg.com/

[ceb8]

@keflavich So there is no public announcement?

[bsipocz]

@ceb8 - We always wait with the public announcement until we have all the packaging ready. This time we had problems building the conda package and will have to release.
We will do the new astroquery after astropy 2.0 is out (we are in the middle of doing that). So I suspect, if everything goes well, that we can announce late tomorrow or over the weekend.

[ceb8]

@bsipocz Where will I go to see that announcement? astropy-dev? I am just confused about what I (as a user) would monitor to be apprised of new features/versions. Or do I just try conda update and see what happens?

[bsipocz]

I think it's usually astropy-dev and Astropy mailing lists. Twitter, and maybe also the python users in astronomy facebook group. But Adam can confirm as he made the announcements.

[ceb8]

@bsipocz Great, thanks! (I may have to get twitter one of these days...)

[keflavich]

astropy-users is a general mailing list. We sometimes announce on twitter, but that's contingent on... me being logged in. Are there other fora we should use?

…

On Thu, Jul 6, 2017 at 4:00 PM, C. Brasseur ***@***.***> wrote: @bsipocz <https://github.com/bsipocz> Great, thanks! (I may have to get twitter one of these days...) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#947 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIxY7FyucOibiWqpyDm2_ncoipW068cks5sLVj9gaJpZM4OM0G5> .

-- Adam

[bsipocz]

@keflavich - I guess maybe we can start posing to the FB group? It has some 2000+ users.

[keflavich]

Twitter is one thing, but fb? bah humbug. (ok, this is a good idea...)

…

On Thu, Jul 6, 2017 at 4:12 PM, Brigitta Sipocz ***@***.***> wrote: @keflavich <https://github.com/keflavich> - I guess maybe we can start posing to the FB group? It has some 2000+ users. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#947 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIxY5HR-fPkK0FDkzj8uUET7rC_cHDOks5sLVvagaJpZM4OM0G5> .

-- Adam

[bsipocz]

It's actually a useful group, keeps the user howto issues away from the repos :)

[bsipocz]

Hmm, astropy-bot is still unhappy but it's rather a bug than a feature, so I'm merging this now.

Thanks @ceb8!

[ceb8]

Thanks @bsipocz !