Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing with int array #18

Merged
merged 3 commits into from
Jun 27, 2016
Merged

Fix indexing with int array #18

merged 3 commits into from
Jun 27, 2016

Conversation

kgabor
Copy link
Contributor

@kgabor kgabor commented Jun 13, 2016

In case of the median cleaning, the update of cleanarr is not performed as expected as indexing with a 2D int array is different from a 2D bool array indexing.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling aa8571d on kgabor:intmask_fix into e28afa4 on astropy:master.

@cmccully
Copy link
Contributor

Hi @kgabor. Sorry I didn't see this PR until today. Yikes. Good catch. Would it be possible to add a test for this to protect against this in the future?

@kgabor
Copy link
Contributor Author

kgabor commented Jun 22, 2016

@cmccully - Hi, please find a small image cutout test where the first iteration does not find all cosmic pixels with the default settings.

@coveralls
Copy link

coveralls commented Jun 22, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 45d00fe on kgabor:intmask_fix into e28afa4 on astropy:master.

@cmccully cmccully merged commit 372c1ed into astropy:master Jun 27, 2016
@cmccully
Copy link
Contributor

Looks good. Thanks @kgabor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants