Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return uncertainty and mask from combine function #775

Merged
merged 3 commits into from May 24, 2021

Conversation

mwcraig
Copy link
Member

@mwcraig mwcraig commented May 23, 2021

This fixes #774 by ensuring that a mask and uncertainty is returned from the combine function.

@mwcraig mwcraig added this to the 2.2.0 milestone May 23, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #775 (f7cf5c6) into main (91f2c46) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   95.94%   96.01%   +0.07%     
==========================================
  Files          30       30              
  Lines        3922     3942      +20     
==========================================
+ Hits         3763     3785      +22     
+ Misses        159      157       -2     
Impacted Files Coverage Δ
ccdproc/tests/test_memory_use.py 89.28% <ø> (-0.72%) ⬇️
ccdproc/combiner.py 94.02% <100.00%> (+0.90%) ⬆️
ccdproc/tests/test_combiner.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f2c46...f7cf5c6. Read the comment docs.

@mwcraig mwcraig merged commit bb9c667 into astropy:main May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncertainty and mask not returned from combine()
1 participant