Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many tests fail with the latest astroscrappy release #777

Closed
mwcraig opened this issue Nov 19, 2021 · 3 comments · Fixed by #778
Closed

Many tests fail with the latest astroscrappy release #777

mwcraig opened this issue Nov 19, 2021 · 3 comments · Fixed by #778

Comments

@mwcraig
Copy link
Member

mwcraig commented Nov 19, 2021

For example, test_cosmicray_gain_correct fails with:

E   TypeError: detect_cosmics() got an unexpected keyword argument 'pssl'
@saimn
Copy link

saimn commented Nov 19, 2021

Oops, yeah several parameters have been renamed. I can have later if you want.

@mwcraig
Copy link
Member Author

mwcraig commented Nov 19, 2021

Oops, yeah several parameters have been renamed. I can have later if you want.

That would be excellent -- if you can point me some documentation (or commit) that has the renames I do have plenty of time today to work on this.

@saimn
Copy link

saimn commented Nov 19, 2021

The changes come from astropy/astroscrappy#53, which allow to properly manage the background for spectroscopy. So data should now include the background. And some keywords were renamed for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants