Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix compatibility with numpy 2.0.0 (copy semantics) #824

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

neutrinoceros
Copy link
Contributor

There are a couple other failing tests with numpy 2 but this one is self contained.
I'll open a different PR for the rest.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (b962f56) to head (2872944).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files           9        9           
  Lines        1392     1392           
=======================================
  Hits         1358     1358           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neutrinoceros neutrinoceros marked this pull request as ready for review April 10, 2024 07:54
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Apr 10, 2024

@mwcraig there's another patch for numpy 2 in #826
And I'm still seeing 3 failing tests locally, but they're about testing scripts and the only info we get from the tests is that the return value is non-zero. Debugging those will probably take a bit longer but I'm getting to it !

update: actually the error I was seeing with scripts had nothing to do with numpy. See #827

@mwcraig mwcraig merged commit dd72ca7 into astropy:main Apr 11, 2024
13 checks passed
@neutrinoceros neutrinoceros deleted the numpy2_compat branch April 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants