make nomkl the default #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(this still needs tests and docs, but I wanted it out of the door) |
astrofrog
requested changes
Sep 8, 2018
|
It's a tiny bit weird that on travis, on the current master (before this PR), mkl is not installed at all but it is for the astropy travis builds. No I don't have good ideas how to test this PR in this repo (but will test the this branch with the astropy travis). |
bsipocz
force-pushed
the
defaul_nomkl
branch
10 times, most recently
from
14342ba
to
2ad5d7d
Compare
bsipocz
force-pushed
the
defaul_nomkl
branch
from
2ad5d7d
to
c124c8f
Compare
|
I think I've addressed all the point of the review, and sadly cannot implement this feature for appveyor as there is no openblas on Windows, everything needs to ship with mkl (conda/conda#6071 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.