Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis add mpl backend setup #38

Merged
merged 2 commits into from
Jan 22, 2016

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jan 9, 2016

This is to address and close #26.

@astrofrog - do we need to test this somehow?

@astrofrog
Copy link
Member

Of course, we could also simply always run those commands - I'm not sure if there would be any downsides?

@astrofrog
Copy link
Member

@bsipocz - I think we should actually just always run these commands, BUT we need to check that the OS is linux.

@bsipocz bsipocz force-pushed the travis_add_mpl_backend_setup branch from a937562 to 9da0154 Compare January 19, 2016 13:36
@bsipocz
Copy link
Member Author

bsipocz commented Jan 19, 2016

@astrofrog - Rebased and removed the env variable so it's always set.
As it's only included in setup_conda_linux.sh, the OS should be linux.

@bsipocz bsipocz force-pushed the travis_add_mpl_backend_setup branch from 33b7486 to 29ddfb1 Compare January 19, 2016 19:47
@bsipocz
Copy link
Member Author

bsipocz commented Jan 19, 2016

Rebased again. And I've also sent a feature request to support@github whether they would consider adding a "Rebase branch" button next to the current "Update branch". Latter merges master back to the given feature branch which we don't like that much.

@bsipocz
Copy link
Member Author

bsipocz commented Jan 19, 2016

@astrofrog - Do you know how to disable the coveralls here, so it can't screw up the statuses? It doesn't make much sense anyway as the only python here is the test itself, and we only run it to make sure we installed all its dependencies.

@astrofrog
Copy link
Member

@bsipocz - I've disabled the coverage status (it's an option on coveralls.io)

@bsipocz
Copy link
Member Author

bsipocz commented Jan 19, 2016

Thanks.

@bsipocz bsipocz force-pushed the travis_add_mpl_backend_setup branch from 29ddfb1 to 3792759 Compare January 19, 2016 22:45
@bsipocz
Copy link
Member Author

bsipocz commented Jan 19, 2016

Rebased on #45 so a new build is triggered (and that one should go in asap as it already causes trouble that the package names are not always lowercase (eg Cython))

@astrofrog
Copy link
Member

@bsipocz - it looks like this will need rebasing

@bsipocz
Copy link
Member Author

bsipocz commented Jan 21, 2016

I'll rebase once we merge #51 (as a rebase is needed after every merge).

@astrofrog
Copy link
Member

@bsipocz - sounds good!

@bsipocz bsipocz force-pushed the travis_add_mpl_backend_setup branch from 3792759 to ef1b7e7 Compare January 22, 2016 12:39
@bsipocz
Copy link
Member Author

bsipocz commented Jan 22, 2016

Rebased

bsipocz added a commit that referenced this pull request Jan 22, 2016
@bsipocz bsipocz merged commit 7c3da22 into astropy:master Jan 22, 2016
@bsipocz
Copy link
Member Author

bsipocz commented Jan 22, 2016

Merged this to avoid YAR (yet another rebase) ;)

@astrofrog
Copy link
Member

Thanks! I just discovered that packages will need to remove these lines otherwise the Travis build fails. I'll email the mailing list for affiliated package maintainers.

@bsipocz
Copy link
Member Author

bsipocz commented Jan 22, 2016

Ouch. Should we set this with an env variable then?

@bsipocz
Copy link
Member Author

bsipocz commented Jan 22, 2016

Also some packages are checking for qt, while others seems to be ok with pyside. Should be put that here, too?

@astrofrog
Copy link
Member

@bsipocz - ok, maybe it makes sense to add an environment variable XVFB for people to opt in. Could you do that? I wouldn't touch the QT_API variable which some packages set though, that's more specialized (is that what you meant?)

@bsipocz
Copy link
Member Author

bsipocz commented Jan 22, 2016

Yes, I'm doing it now. And yes, that's what I meant, that we cannot do it being generic enough anyway to make all the affiliated packages happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mpl setup as an opt-in
2 participants