-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis add mpl backend setup #38
Conversation
Of course, we could also simply always run those commands - I'm not sure if there would be any downsides? |
@bsipocz - I think we should actually just always run these commands, BUT we need to check that the OS is linux. |
a937562
to
9da0154
Compare
@astrofrog - Rebased and removed the env variable so it's always set. |
33b7486
to
29ddfb1
Compare
Rebased again. And I've also sent a feature request to support@github whether they would consider adding a "Rebase branch" button next to the current "Update branch". Latter merges master back to the given feature branch which we don't like that much. |
@astrofrog - Do you know how to disable the coveralls here, so it can't screw up the statuses? It doesn't make much sense anyway as the only python here is the test itself, and we only run it to make sure we installed all its dependencies. |
@bsipocz - I've disabled the coverage status (it's an option on coveralls.io) |
Thanks. |
29ddfb1
to
3792759
Compare
Rebased on #45 so a new build is triggered (and that one should go in asap as it already causes trouble that the package names are not always lowercase (eg Cython)) |
@bsipocz - it looks like this will need rebasing |
I'll rebase once we merge #51 (as a rebase is needed after every merge). |
@bsipocz - sounds good! |
3792759
to
ef1b7e7
Compare
Rebased |
Merged this to avoid YAR (yet another rebase) ;) |
Thanks! I just discovered that packages will need to remove these lines otherwise the Travis build fails. I'll email the mailing list for affiliated package maintainers. |
Ouch. Should we set this with an env variable then? |
Also some packages are checking for qt, while others seems to be ok with pyside. Should be put that here, too? |
@bsipocz - ok, maybe it makes sense to add an environment variable |
Yes, I'm doing it now. And yes, that's what I meant, that we cannot do it being generic enough anyway to make all the affiliated packages happy. |
This is to address and close #26.
@astrofrog - do we need to test this somehow?